Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't replay commands from non-completed task #1750

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Don't replay commands from non-completed task #1750

wants to merge 14 commits into from
+340 −1

Conversation

yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Dec 9, 2024

What was changed

Skip any commands that aren't a part of a completed WFT (a.k.a. if WFT start is the last event)

Why?

Fix issue where we're hitting NDE when we shouldn't be.

Checklist

  1. Closes Erroneous extra replay command when replaying mid-workflow tasks #1670

  2. How was this tested:

Added new test

  1. Any docs updates needed?

@yuandrew yuandrew requested a review from a team as a code owner December 9, 2024 23:03
cretz
cretz reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test that has a full history that replays successfully in the replayer, then confirm it continually succeeds in a replayer popping one event off the end each time?

Also, would like @Quinn-With-Two-Ns to look at this PR when he's available before we merge.

internal/internal_task_handlers.go Outdated Show resolved Hide resolved
internal/internal_task_handlers.go Outdated Show resolved Hide resolved
internal/internal_task_handlers.go Outdated Show resolved Hide resolved
yuandrew
yuandrew commented Jan 8, 2025
View reviewed changes
test/integration_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns left review comments

@cretz cretz cretz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous extra replay command when replaying mid-workflow tasks
3 participants
@yuandrew @cretz @Quinn-With-Two-Ns